Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2658 - allow await on transient properties #2667

Closed
wants to merge 1 commit into from
Closed

Fixes #2658 - allow await on transient properties #2667

wants to merge 1 commit into from

Conversation

codyebberson
Copy link
Contributor

Fixes #2658 - see issue for more details

@codyebberson
Copy link
Contributor Author

From the build failure:

yarn config set registry "${ARTIFACTORY_URL}/api/npm/npm"
/tmp/scripts52fdfc072182654f163f5f0f9a621d72.sh: line 6: ARTIFACTORY_URL: unbound variable

This seems unrelated to the files changed.

@spartanatreyu
Copy link

Is there something holding this back?

Not being able to use promises/async/await in JS/TS files is a big deal when all modern libraries are built upon them.

I can't trust the linter until this is fixed.

@codyebberson
Copy link
Contributor Author

@spartanatreyu - see #2636 (comment)

My understanding is that they found some deeper issues with the tsconfig, so we're waiting for that.

@spartanatreyu
Copy link

Ah, I can see it on the 8.3 milestone now, awesome.

@vilchik-elena vilchik-elena self-assigned this Aug 9, 2021
@vilchik-elena
Copy link
Contributor

Closing PR, it will be merged as part of #2755 (with a different approach applied)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FP S4123 (no-invalid-await): TypeScript Pick type
3 participants