-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle out-of-memory errors in the worker thread #4273
Conversation
b76bc14
to
423328b
Compare
Non-verbose logsBefore
After
|
Verbose logsBefore
After
|
Unrelated, but I wonder whether those logs should be printed at debug-level.
What do you think? I mean we are mixing log levels about Node.js, and it's hard to tell what should be at info-level and what should be at debug-level.. |
Also unrelated, but I would like to change these logs from:
to
Would that be any better? Am I just nitpicking? |
it's bit of a detail, I can create PR later today to improve this logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on cleaning up and rewording the logs
SonarQube Quality Gate |
Fixes #4254
When the worker thread runs out of memory, here is the new behavior to expect:
Since it's kinda tricky to write a unit test or an integration for that, I checked manually this behaviour.
To do so, I analyzed TypeScript with
sonar.javascript.node.maxspace=512
to make Node.js run out of memory.Below are comparisons of the logs we print before and after the changes of this pull request.