Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule S6827 (jsx-a11y/anchor-has-content): Anchors should contain accessible content #4296

Merged
merged 9 commits into from
Oct 19, 2023

Conversation

ilia-kebets-sonarsource
Copy link
Contributor

Fixes #4279

* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
export { rule } from './rule';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest removing this and just renaming rule.ts to index.ts

Copy link
Contributor

@alex-sonar alex-sonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqube-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ilia-kebets-sonarsource ilia-kebets-sonarsource merged commit 9ef0874 into master Oct 19, 2023
15 checks passed
@ilia-kebets-sonarsource ilia-kebets-sonarsource deleted the issue-4279/S6827-anchor-content branch October 19, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create rule S6827 (jsx-a11y/anchor-has-content): Anchors should contain accessible content
3 participants