Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule S6848 (jsx-a11y/no-static-element-interactions): Non-interactive DOM elements should not have an interactive handler #4385

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Add rule S6848 (jsx-a11y/no-static-element-interactions): Non-interactive DOM elements should not have an interactive handler #4385

merged 2 commits into from
Nov 15, 2023

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #4286

@yassin-kammoun-sonarsource
Create rule S6848 (jsx-a11y/no-static-element-interactions): Non-in…
000c44d 
…teractive DOM elements should not have an interactive handler
@ilia-kebets-sonarsource ilia-kebets-sonarsource changed the title Create rule S6848 (jsx-a11y/no-static-element-interactions): Non-interactive DOM elements should not have an interactive handler Add rule S6848 (jsx-a11y/no-static-element-interactions): Non-interactive DOM elements should not have an interactive handler Nov 15, 2023
@ilia-kebets-sonarsource
Copy link
Contributor

This looks quite noisy, WDYT?

@yassin-kammoun-sonarsource
Copy link
Contributor Author

This looks quite noisy, WDYT?

Do you really think that ~400 issues is noisy?

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@yassin-kammoun-sonarsource
Copy link
Contributor Author

Can we merge?

ilia-kebets-sonarsource
ilia-kebets-sonarsource approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 9ae9b4b into master Nov 15, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilia-kebets-sonarsource ilia-kebets-sonarsource ilia-kebets-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yassin-kammoun-sonarsource @ilia-kebets-sonarsource