-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rule S5973: Tests should be stable #4443
Conversation
As mentioned, there seems to be some kind of issue with the error message that I run into when executing the ruling test, which prevents the plugin from creating the expected issues:
|
...n/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S5973.html
Show resolved
Hide resolved
...n/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S5973.json
Show resolved
Hide resolved
f33162e
to
bb40f33
Compare
e3c93de
to
abf27ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add caches to package-json utils module and we should be good
…eparate `package.json` dependencies
abf27ba
to
5437828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! :)
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
I have received another one from victor
Fixes #4429