Upgrade typescript-eslint

[saberduck]

No description provided.

[saberduck]

This is the current status of the ruling differences. @ilia-kebets-sonarsource @vdiez I would appreciate if you could help me with the review. I suggest we split by rules - each person takes one rule (both js and ts)

[ilia-kebets-sonarsource]

Here are the suspect cases I encountered:

S3863: Imports from the same module should be merged

• same path flagged twice
  desktop > app/src/ui/index.tsx: line 37 and 44
• implementation proposal: add secondary locations
  • useful especially when there is more than one secondary: like ag-grid > src/ts/columnController/balancedColumnTreeBuilder.ts lines 11 - 14
• documentation proposal: maybe add a coding example for cases where you need to combine the export of properties and some default value like : import React, { Component } from React

S2201: Return values from functions without side effects should not be ignored

• missing valid errors:
  • desktop > app/src/lib/fix-emoji-spacing.ts: line 34: container.offsetHeight.toString()
  • desktop > app/src/lib/source-map-support.ts: line 127: ;(error.stack || '').toString()

S4325: Redundant casts and non-null assertions should be avoided

• Missing valid errors:
  • ag-grid > src/ts/entities/column.ts: line 227, 243

if (typeof this.colDef.suppressNavigable === 'boolean') {
  return <boolean> this.colDef.suppressNavigable;

if (typeof this.colDef.editable === 'boolean') {
  return <boolean> this.colDef.editable;

• ag-grid > src/ts/rendering/renderedCell.ts: line 201

} else if (typeof colDef.checkboxSelection === 'boolean') {
  this.usingWrapper = <boolean> colDef.checkboxSelection;

• ant-design > site/theme/template/IconDisplay/index.tsx: line 87

const categoriesResult = Object.keys(categories)
  .map((key: CategoriesKeys) => {
// ...
<Category
  key={category}
  title={category as CategoriesKeys}
// ...
/>

S3981: Collection size and array length comparisons should make sense

• implementation proposal: it might be nice to have a secondary location to know what condition or declaration verifies the redundant condition, but lots of work:
  • es5-shim > es5-shim.js: line 1084

        return value !== null
            && typeof value === 'object'
            && typeof value.length === 'number'
            && value.length >= 0

S2260: JS parser failure

• interesting that this is introduced now. I don't know what to think:
  • jshint > tests/unit/fixtures/emptystmt.js: line 1 ("var;")

[saberduck]

Changes for S6582 come from the fact that @typescript-eslint provides services.program also in cases when it was not available before. The rule was doing early exit when services.program was not available. There were also some improvements to the rule logic itself, typescript-eslint/typescript-eslint@02a37c4

[sonarqube-next]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
98.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[ilia-kebets-sonarsource]

is there a reason not to use the utils from SonarJS

[saberduck]

not really, we could

[ilia-kebets-sonarsource]

LGTM!