Improve S4123 (no-invalid-await): Improve documentation about edge cases and add test to confirm that S4123 honours JSDoc directives
#4538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmorand-sonarsource
force-pushed
the
issue-4516-S4123
branch
from
b237bc2
to
bff7454
Compare
ilia-kebets-sonarsource
changed the title
no-invalid-await): Improve documentation about edge cases and add test to confirm that S4123 honours JSDoc directives
ericmorand-sonarsource
force-pushed
the
issue-4516-S4123
branch
from
bff7454
to
febae3f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4516