-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FP S6594 (sonar-prefer-regexp-exec
): Ignore match count use case
#4540
Conversation
* Extracts the left-hand side variable of expressions | ||
* like `x` in `const x = <node>` or `x` in `x = <node>`. | ||
*/ | ||
function getLhsVariable(node: estree.Node) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't it the same as https://sonarsource.github.io/SonarJS/typedoc/functions/getLhsVariable.html ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arf, I forgot to replace this one with my implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I think I will keep my duplicate because the function signature is a bit different, and I am not sure I would like to merge both and impact other rules.
Co-authored-by: Ilia Kebets <[email protected]>
Co-authored-by: Ilia Kebets <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments, otherwise LGTM!
Quality Gate passedIssues Measures |
Fixes #4532