Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FP S6606 (prefer-nullish-coalescing): When the first argument s boolean | undefined #4565

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

ericmorand-sonarsource
Copy link
Contributor

Also when first argument is string | undefined and number | undefined

Fixes #3936

…s boolean | undefined

Also when first argument is `string | undefined` and `number | undefined`
@yassin-kammoun-sonarsource
Copy link
Contributor

You will need to declare the rule explicitly in packages/jsts/src/rules/index.ts now that it is decorated.

@ericmorand-sonarsource
Copy link
Contributor Author

@yassin-kammoun-sonarsource , can you please review this PR once more? I removed the string and number exceptions and it involved a few changes in the its tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@ericmorand-sonarsource ericmorand-sonarsource merged commit 6402d1a into master Feb 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix FP S6606 (prefer-nullish-coalescing): When the first argument is boolean | undefined
2 participants