Resolve JS-3 Stricter rule implementation for detecting a valid header #4662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
assigned yassin-kammoun-sonarsource and vdiez and unassigned yassin-kammoun-sonarsource
|
vdiez
approved these changes
Apr 18, 2024
| const rows: TableCell[][] = []; | ||
| let unknownTableStructure = false; | ||
| tree.children.forEach(child => { | ||
| if (child.type === 'JSXElement') { |
There was a problem hiding this comment.
reminder: handle JSXFragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to expand on the logic in https://github.com/SonarSource/sonar-html/blob/master/sonar-html-plugin/src/main/java/org/sonar/plugins/html/checks/sonar/TableWithoutHeaderCheck.java
Trying to be stricter about the implementation and the logic applied is as follows:
<table>'s)For the most part following the spec - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/th
The only missing thing is not breaking up separately the
<thead>,<tbody>and<tfoot>and running the full grid check.