Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS-11] Rename rule S6854 to S1090 #4666

Merged
merged 5 commits into from
Apr 18, 2024
Merged

[JS-11] Rename rule S6854 to S1090 #4666

merged 5 commits into from
Apr 18, 2024

Conversation

vdiez
Copy link
Contributor

@vdiez vdiez commented Apr 18, 2024 •
edited
Loading

@vdiez vdiez changed the title [JS-11] Rename s6854 [JS-11] Rename S6854 Apr 18, 2024
@vdiez vdiez changed the title [JS-11] Rename S6854 [JS-11] Rename S6854 to S1090 Apr 18, 2024
@vdiez vdiez changed the title [JS-11] Rename S6854 to S1090 [JS-11] Rename rule S6854 to S1090 Apr 18, 2024
zglicz
zglicz approved these changes Apr 18, 2024
View reviewed changes
...-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/Sonar_way_profile.json
@@ -326,7 +326,7 @@
"S6851",
"S6852",
"S6853",
"S6854",
"S1090",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to have these sorted? In the future, it'd make it much easier to check if sth is in this list

@vdiez vdiez enabled auto-merge (squash) April 18, 2024 13:52
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@vdiez vdiez merged commit 84a3e14 into master Apr 18, 2024
14 checks passed
@vdiez vdiez deleted the rename-S6854 branch April 18, 2024 14:15
@vdiez vdiez added this to the 10.14.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zglicz zglicz zglicz approved these changes

Assignees

@vdiez vdiez

Labels
None yet
Projects
None yet
Milestone
10.14
Development

Successfully merging this pull request may close these issues.
2 participants
@vdiez @zglicz