-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve JS-150 #4680
Resolve JS-150 #4680
Conversation
packages/jsts/src/rules/S107/rule.ts
Outdated
@@ -137,7 +134,7 @@ export const rule: RuleModule<Options> = { | |||
|
|||
function checkFunction(node: estree.Node) { | |||
const functionLike = node as unknown as TSESTree.FunctionLike; | |||
const maxParams = (context.options as Options)[0].maximumFunctionParameters; | |||
const maxParams = (context.options as Options)[0].max; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
destruct?
@@ -25,7 +25,7 @@ const MAX_PARAMS_3 = 3; | |||
const MAX_PARAMS_5 = 5; | |||
|
|||
const createOptions = (maximumFunctionParameters: number): Options => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps remove the name "maximumFunctionParameters" throughout the rules codebase?
I'll do another release, so maybe could you base your version on plugin v1.0.2? |
4541b9f
to
3a28732
Compare
3a28732
to
54367ad
Compare
Quality Gate passedIssues Measures |
Fixes JS-150