JS-161 Separate bridge from sonar-javascript-plugin #4697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saberduck
changed the title
saberduck
commented
May 23, 2024
saberduck
commented
May 23, 2024
...script-plugin/src/main/java/org/sonar/plugins/javascript/analysis/cache/CacheStrategies.java
Show resolved
Hide resolved
saberduck
commented
May 23, 2024
...plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/JavaScriptFilePredicate.java
Outdated
Show resolved
Hide resolved
sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/BridgeServerImpl.java
Show resolved
Hide resolved
sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/EslintRule.java
Show resolved
Hide resolved
| @@ -185,7 +183,7 @@ void should_get_answer_from_server() throws Exception { | |||
| .setContents("alert('Fly, you fools!')") | |||
| .build(); | |||
| JsAnalysisRequest request = createRequest(inputFile); | |||
| assertThat(bridgeServer.analyzeJavaScript(request).issues).isEmpty(); | |||
| assertThat(bridgeServer.analyzeJavaScript(request).issues()).hasSize(1); | |||
There was a problem hiding this comment.
how come we are getting an issue now?
There was a problem hiding this comment.
I changed the startServer script to return some issue, in order to have code coverage in BridgeServer
There was a problem hiding this comment.
Thanks for the explanation
sonar-plugin/bridge/src/test/java/org/sonar/plugins/javascript/bridge/BridgeServerImplTest.java
Show resolved
Hide resolved
sonar-plugin/bridge/src/test/java/org/sonar/plugins/javascript/bridge/BridgeServerImplTest.java
Show resolved
Hide resolved
sonar-plugin/bridge/src/test/java/org/sonar/plugins/javascript/bridge/BridgeServerImplTest.java
Show resolved
Hide resolved
sonar-plugin/bridge/src/test/java/org/sonar/plugins/javascript/bridge/BridgeServerImplTest.java
Show resolved
Hide resolved
...in/bridge/src/test/java/org/sonar/plugins/javascript/bridge/JavaScriptFilePredicateTest.java
Outdated
Show resolved
Hide resolved
...vascript-plugin/src/main/java/org/sonar/plugins/javascript/analysis/cache/CpdSerializer.java
Show resolved
Hide resolved
.../sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/bridge/BridgeServer.java
Outdated
Show resolved
Hide resolved
...ascript-plugin/src/test/java/org/sonar/plugins/javascript/analysis/cache/CacheTestUtils.java
Show resolved
Hide resolved
ilia-kebets-sonarsource
suggested changes
May 24, 2024
hashicorp-vault-sonar-prod
bot
assigned saberduck and unassigned ilia-kebets-sonarsource
hashicorp-vault-sonar-prod
bot
assigned ilia-kebets-sonarsource and unassigned saberduck
ilia-kebets-sonarsource
approved these changes
May 24, 2024
hashicorp-vault-sonar-prod
bot
assigned saberduck and unassigned ilia-kebets-sonarsource
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes were made in
BridgeServerto improve the overall coderecordwhich makes the fieldsfinaland private, they are available through accessor methods (thus change of field access to method invocation())js,ts,yaml) to avoid circular dependency betweenbridgeandsonar-javascript-pluginpublic, because there is too much sharing betweenbridgeandsonar-javascript-plugin, when we will migrate more logic to the Node.js part, we will be able to improve this