JS-154: Bridge sends AST to plugin as `multipart/form-data` #4711

ilia-kebets-sonarsource · 2024-05-27T17:05:43Z

No description provided.

packages/bridge/src/worker.js

its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/SonarJsIntegrationTest.java

sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/BridgeServerImpl.java

sonar-plugin/bridge/src/test/resources/mock-bridge/package.json

ilia-kebets-sonarsource · 2024-05-30T10:04:47Z

Quality Gate failed

Failed conditions 2 New issues 87.3% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

I don't understand the coverage issues for both these files, as they are indeed used in the tests:

sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/FormDataUtils.java

sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/BridgeServerImpl.java

saberduck

see some minor comments, otherwise lgtm!

… kind

sonarqube-next · 2024-05-31T07:26:44Z

Quality Gate failed

Failed conditions
85.7% Coverage on New Code (required ≥ 90%)

See analysis details on SonarQube

kebetsi added 9 commits May 27, 2024 16:16

return arbitrary string in response body 'ast' prop

9d9dd8a

reply with form-data server side

0feab0d

adapt other tests

26b4bd2

java-part first-try

f8ef04b

Merge branch 'master' into JS-154-bridge-sends-AST-to-plugin

e64759f

parse JSON multipart correctly for /analyze-js

5aaa682

refactor form data parsing code into its own method

863f3b6

adapt other bridge calls

0e234ea

remove separate implementation for tests

b47c6af

ilia-kebets-sonarsource commented May 29, 2024

View reviewed changes

packages/bridge/src/worker.js Outdated Show resolved Hide resolved

kebetsi added 3 commits May 29, 2024 15:15

generate ast prop for other files as well

54422f2

fix issues

b01dd68

fix compilation errors

1472fee

ilia-kebets-sonarsource marked this pull request as ready for review May 29, 2024 13:36

kebetsi added 5 commits May 29, 2024 15:55

fix analysis errors

f35478d

add 'form-data' to bundledDependencies

9ff2f4a

cleanup and fix IT

0208a92

put back check

1e8ba59

put back throws exception

a39d70d

ilia-kebets-sonarsource force-pushed the JS-154-bridge-sends-AST-to-plugin branch from 94d20b9 to a39d70d Compare May 29, 2024 15:55

kebetsi added 3 commits May 30, 2024 08:30

cleanup tests

985a66d

fix test

0966504

improve coverage on parseFormData

fb5476f

ilia-kebets-sonarsource requested a review from saberduck May 30, 2024 09:44

hashicorp-vault-sonar-prod bot assigned saberduck May 30, 2024

ilia-kebets-sonarsource commented May 30, 2024

View reviewed changes

its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/SonarJsIntegrationTest.java Show resolved Hide resolved

ilia-kebets-sonarsource commented May 30, 2024

View reviewed changes

sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/BridgeServerImpl.java Show resolved Hide resolved

ilia-kebets-sonarsource commented May 30, 2024

View reviewed changes

sonar-plugin/bridge/src/test/resources/mock-bridge/package.json Outdated Show resolved Hide resolved

kebetsi added 2 commits May 30, 2024 11:57

fix issues

aa21386

remove package.json and its lockfile

0e91b3c

kebetsi added 4 commits May 30, 2024 13:38

fix issue

151e5e9

refactor mock-bridge startServer.js script to not use 'form-data' lib

3da0a20

refactor tests to display newlines clearer

012cac2

Merge branch 'master' into JS-154-bridge-sends-AST-to-plugin

ff69568

saberduck reviewed May 30, 2024

View reviewed changes

sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/FormDataUtils.java Show resolved Hide resolved

saberduck reviewed May 30, 2024

View reviewed changes

sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/FormDataUtils.java Show resolved Hide resolved

saberduck reviewed May 30, 2024

View reviewed changes

sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/BridgeServerImpl.java Outdated Show resolved Hide resolved

kebetsi added 2 commits May 30, 2024 17:17

add missing file header

d7922c5

add newline

9644ece

saberduck approved these changes May 30, 2024

View reviewed changes

hashicorp-vault-sonar-prod bot assigned ilia-kebets-sonarsource and unassigned saberduck May 30, 2024

kebetsi added 2 commits May 30, 2024 17:33

use content-type header instead of boolean to figure out the response…

666b9b1

… kind

fix issue

ee1d7bd

ilia-kebets-sonarsource merged commit 70b20d7 into master May 31, 2024
13 of 15 checks passed

ilia-kebets-sonarsource deleted the JS-154-bridge-sends-AST-to-plugin branch May 31, 2024 07:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JS-154: Bridge sends AST to plugin as `multipart/form-data` #4711

JS-154: Bridge sends AST to plugin as `multipart/form-data` #4711

ilia-kebets-sonarsource commented May 27, 2024

ilia-kebets-sonarsource commented May 30, 2024

Quality Gate failed

saberduck left a comment

sonarqube-next bot commented May 31, 2024

JS-154: Bridge sends AST to plugin as multipart/form-data #4711

JS-154: Bridge sends AST to plugin as multipart/form-data #4711

Conversation

ilia-kebets-sonarsource commented May 27, 2024

ilia-kebets-sonarsource commented May 30, 2024

Quality Gate failed

saberduck left a comment

Choose a reason for hiding this comment

sonarqube-next bot commented May 31, 2024

Quality Gate failed

JS-154: Bridge sends AST to plugin as `multipart/form-data` #4711

JS-154: Bridge sends AST to plugin as `multipart/form-data` #4711