Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS-159 Send real AST using protobufjs #4716

Merged
merged 66 commits into from
Jun 10, 2024
Merged

JS-159 Send real AST using protobufjs #4716

merged 66 commits into from
Jun 10, 2024

Conversation

ilia-kebets-sonarsource
Copy link
Contributor

No description provided.

kebetsi and others added 28 commits May 31, 2024 16:29
@kebetsi
try something with protobufjs
f62baab
@kebetsi
fix end location
439e440
@kebetsi
dynamic serialization - first attempt
edc866e
@kebetsi
test for non null keys
131ac98
@kebetsi
use res instead of node
7853327
@kebetsi
refactor function name for clarity
4808d49
@kebetsi
Merge branch 'master' into JS-159-send-real-AST-using-protobuf
7131a64
@kebetsi
fix merge
fbc9dda
@quentin-jaquier-sonarsource
Start implementation
db6b651
@quentin-jaquier-sonarsource
Use correct serializer
c56d1d6
@quentin-jaquier-sonarsource
Start to handle literals
a9a2ff9
@quentin-jaquier-sonarsource
Finish the visitor implementation
f065e65
@kebetsi
fix path
bf44d08
@quentin-jaquier-sonarsource
Finish first draft
e743969
@kebetsi
setup jest for tests
b2408a2
@kebetsi
Merge branch 'qj/NewProtobuf' into JS-159-send-real-AST-using-protobuf
45e1b9d
@quentin-jaquier-sonarsource
fix protobuf file
39fe6fa
@quentin-jaquier-sonarsource
Handle function expression name conflict
a9aa719
@quentin-jaquier-sonarsource
Revert "fix protobuf file"
d568762 
This reverts commit 39fe6fa.
@quentin-jaquier-sonarsource
Start autogeneration
e1be9c8
@kebetsi
fix visitNode
0313e14
@kebetsi
cleanup and setup deserialize debug
41241d3
@kebetsi
ugly: return {node, type} in case the type and type prop are differ…
a0da501 
…ent, like literals and callExpressions
@quentin-jaquier-sonarsource
Do not create intermediate messages
695676c
@quentin-jaquier-sonarsource
Clean up
2b3a5e9
@ilia-kebets-sonarsource
implement ast compare (#4729)
8697a8d
@quentin-jaquier-sonarsource
Fix after rebase
5b1c72b
@kebetsi
add TS classes for protobuf
b659c6a
kebetsi and others added 20 commits June 7, 2024 09:49
@kebetsi
monkey patch TS AST serialization until we fix it
a532521
@kebetsi
fix patch
de41da6
@quentin-jaquier-sonarsource
Fix Sonar issues
5f777ec
@kebetsi
add copy of protobuf to bridge
6999582
@kebetsi
Merge branch 'JS-159-send-real-AST-using-protobuf' of github.com:Sona…
c0ee148 
…rSource/SonarJS into JS-159-send-real-AST-using-protobuf
@kebetsi
adapt script
2f6cd1e
@quentin-jaquier-sonarsource
Add further tests for coverage
df0acf5
@kebetsi
Revert "adapt script"
a275774 
This reverts commit 2f6cd1e.
@kebetsi
copy the protofile to the lib
eadf408
@kebetsi
Merge branch 'JS-159-send-real-AST-using-protobuf' of github.com:Sona…
6b3022e 
…rSource/SonarJS into JS-159-send-real-AST-using-protobuf
@kebetsi
also copy to packages/
c9d38a8
@quentin-jaquier-sonarsource
Merge branch 'master' into JS-159-send-real-AST-using-protobuf
67c5fd6
@kebetsi
filter out other files that are currently unsupported
30bea5d
@kebetsi
refactor check
5364a55
@kebetsi
Merge branch 'JS-159-send-real-AST-using-protobuf' of github.com:Sona…
98f7572 
…rSource/SonarJS into JS-159-send-real-AST-using-protobuf
@kebetsi
don't crash on unknown nodes
64dad2d
@kebetsi
comment out assertion that will be fixed in next ticket
ac5d94a
@kebetsi
try to fix sonar issues
fcd9304
@kebetsi
Revert "try to fix sonar issues"
99b7dca 
This reverts commit fcd9304.
@kebetsi
remove comment
96458d9
saberduck
saberduck reviewed Jun 7, 2024
View reviewed changes
tools/estree/get-estree-nodes.ts
@@ -27,11 +27,10 @@ export type UnionFieldValue = {

export type Declaration = ts.InterfaceDeclaration | ts.TypeAliasDeclaration;

export const TOP_LEVEL_NODE = 'BaseNodeWithoutComments';
export const TOP_LEVEL_NODE = 'Node';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change somehow changes the handling of DefaultExport node, not sure why. Just a remark

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
23 Accepted issues

Measures
0 Security Hotspots
91.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@ilia-kebets-sonarsource ilia-kebets-sonarsource marked this pull request as ready for review June 10, 2024 07:08
@ilia-kebets-sonarsource ilia-kebets-sonarsource merged commit b84d0f8 into master Jun 10, 2024
14 of 15 checks passed
@ilia-kebets-sonarsource ilia-kebets-sonarsource deleted the JS-159-send-real-AST-using-protobuf branch June 10, 2024 07:10
ilia-kebets-sonarsource pushed a commit that referenced this pull request Jul 3, 2024
@kebetsi
cleanup: it was pushed by mistake in #4716
3199807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saberduck saberduck saberduck approved these changes

Assignees

@ilia-kebets-sonarsource ilia-kebets-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilia-kebets-sonarsource @saberduck @kebetsi @quentin-jaquier-sonarsource