Do not serialize the AST if the skipAst flag is set
#4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilia-kebets-sonarsource
changed the title
skipAst flag is set
Comment on lines
95
to
96
| const ast = serializeAst(sourceCode, filePath, input.skipAst); | ||
| if (ast) { |
There was a problem hiding this comment.
Oups, that was my initial suggestion that led to this imprecision...
Nice catch anyway.
I still think it feels strange to pass this argument. What about:
if (!input.skipAst) {
const ast = serializeAst(sourceCode, filePath);
if (ast) {
result.ast = ast;
}
}
There was a problem hiding this comment.
Both are not great. I'll add your suggestion.
hashicorp-vault-sonar-prod
bot
assigned quentin-jaquier-sonarsource and unassigned quentin-jaquier-sonarsource
|
quentin-jaquier-sonarsource
approved these changes
Jun 14, 2024
quentin-jaquier-sonarsource
deleted the
fix/do-not-serialized-if-skipAst-flag-is-on
branch
hashicorp-vault-sonar-prod
bot
assigned ilia-kebets-sonarsource and unassigned quentin-jaquier-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we skip the AST serialization, not just the sending of the AST in the response.