Resolves JS-278 #4769
Merged
Resolves JS-278 #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmorand-sonarsource
force-pushed
the
JS-278
branch
19 times, most recently
from
77a72b6
to
c1b81a1
Compare
ericmorand-sonarsource
force-pushed
the
JS-278
branch
from
c1b81a1
to
cb0d1f9
Compare
This commit removes the concept of ESLint key from the backend. The rational is that the usage of ESLint is an implementation detail of the frontend that must not propagate to the other layers: would we want to totally change the way the frontend detect issues, the backend should not be impacted at all. Rationality aside, this change removes the requirements of maintaining a mapping between the ESLint keys and their RSpec counterparts, which will make our life easier in the future. Java checks now have RSpec identifiers only. To preserve compatiblity with potential plugins that depend on this one, the semantic `eslintKey` was left untouched, but now means "RSpec identifier". Only the tests that contained the rule key in their expectation have been updated. Other tests, and especially ruling tests, were left untouched. A word about the ESLint plugin: in order to not break the public contract of the ESLint plugin that is also built from the frontend code, the ESLint keys have been kept in the rules entry point.
ericmorand-sonarsource
force-pushed
the
JS-278
branch
from
cb0d1f9
to
d74fa41
Compare
vdiez
approved these changes
Aug 22, 2024
sonar-plugin/api/src/main/java/org/sonar/plugins/javascript/api/Check.java
Show resolved
Hide resolved
saberduck
reviewed
Aug 22, 2024
sonar-plugin/api/src/main/java/org/sonar/plugins/javascript/api/TestFileCheck.java
Outdated
Show resolved
Hide resolved
* Remove the "number of rules in public API" test entirely * Improve the Linter Wrapper test to ignore only SXXX fixtures instead of being super permissive * Remove the unneeded and confusing `@Rule` annotation on TestFileCheck abstract class
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JS-278
Please read the commit messages for more information.
Also, this may seem like a big change according to the number of files changed, but around 440 of these files are Java Check subclasses where the
eslintKeypublic getter was removed. You can safely ignore them and focus on the 20 or so relevant changes that this PR brings.