JS-312 Improve S1607 (no-skipped-tests): Allow explanation comments adjacent to the disabled test
#4804
Conversation
…the disabled test
yassin-kammoun-sonarsource
force-pushed
the
improve-JS-312
branch
from
e484a51
to
363eb6d
Compare
ilia-kebets-sonarsource
changed the title
no-skipped-tests): Allow explanation comments after the disabled testno-skipped-tests): Allow explanation comments after the disabled test
|
@yassin-kammoun-sonarsource Great idea to tackle the line after, but why not handle when the explanation comment is on the same line as well? |
| function isAdjacent(comment: estree.Comment, node: estree.Node) { | ||
| const commentLine = comment.loc!.end.line; | ||
| const nodeLine = node.loc!.start.line; | ||
| return commentLine === nodeLine - 1 || commentLine === nodeLine + 1; |
There was a problem hiding this comment.
If we consider my comment here,
This could be:
| return commentLine === nodeLine - 1 || commentLine === nodeLine + 1; | |
| return Math.abs(commentLine - nodeLine) <= 1; |
There was a problem hiding this comment.
I'm not sure how it could be tested in the comment-based framework though.
There was a problem hiding this comment.
Yeah, I was going to, but I just don't know how to test that.
Any suggestions?
There was a problem hiding this comment.
Another option is to use relative line increments (@+line_increment) or decrements (@-line_decrement):
// Noncompliant@+1
some.faulty.code();
another.faulty.code();
// another comment
// Noncompliant@-2from DEV.md
There was a problem hiding this comment.
Thank you so much for remembering it!
|
yassin-kammoun-sonarsource
changed the title
no-skipped-tests): Allow explanation comments after the disabled testno-skipped-tests): Allow explanation comments adjacent to the disabled test
While validating S1607 on Peach, I encountered some false positives where a disabled test has an explanation comment that follows the test, such as this issue.
RSPEC's change to review