ESLINTJS-53 Fix incompatibilities with ESLint 9 #4818
Conversation
| // @ts-ignore | ||
| getSource(...args) { | ||
| return originalContext.sourceCode.getText(...args); | ||
| }, | ||
|
|
There was a problem hiding this comment.
above you are using originalContext.getAncestors();, originalContext.getScope(); and originalContext.markVariableAsUsed(name);
Apparently, these now requires a node as an argument https://eslint.org/docs/latest/use/migrate-to-9.0.0#-removed-multiple-context-methods
There was a problem hiding this comment.
The ones in the sourceCode object require a node. This overrides the context and forwards the same call. Tomorrow, I'll check how many of the decorated rules use those methods.
|
|
Sorry there are many changes related to removing completely ESLint ids, work started in JS-278 |
There was a problem hiding this comment.
Out of curiosity, were these fixtures not used?
Fixes https://sonarsource.atlassian.net/browse/ESLINTJS-53
Fixes https://sonarsource.atlassian.net/browse/JS-297