JS-259 Do not warn against active Node.js versions

[yassin-kammoun-sonarsource]

No description provided.

[yassin-kammoun-sonarsource]

The ticket mentions testing the CI against all active Node.js versions.
This will really slow down our pull requests.
Is it really something we want to do?

[yassin-kammoun-sonarsource]

How were 18.18.0 and 20.9.0 chosen?
Should they be updated according to the current latest versions?

[saberduck]

I believe the minor versions follow ESLint package.json engine field https://github.com/eslint/eslint/blob/main/package.json#L204 , I wouldn't update unless we have a reason to

[yassin-kammoun-sonarsource]

👍

[yassin-kammoun-sonarsource]

The following dates have expired for a while now:

SonarJS/sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/NodeDeprecationWarning.java

Lines 43 to 46 in 5f03925

	static final Map<Integer, String> REMOVAL_DATE = Map.ofEntries(
	entry(16, "Jan 31th, 2024"),
	entry(17, "Jan 31th, 2024")
	);

However, we still log the following message:

SonarJS/sonar-plugin/bridge/src/main/java/org/sonar/plugins/javascript/bridge/NodeDeprecationWarning.java

Lines 65 to 70 in 5f03925

	String msg = String.format(
	"Using Node.js version %d to execute analysis is deprecated and will stop being supported no earlier than %s." +
	" Please upgrade to a newer LTS version of Node.js %s",
	actualNodeVersion,
	REMOVAL_DATE.get(actualNodeVersion),
	RECOMMENDED_NODE_VERSIONS

Should we officially acknowledge and announce that we don't support Node.js 16 and Node.js 17?

[saberduck]

@yassin-kammoun-sonarsource I think the decision about Node 16 was properly announced, so you can cleanup the code and remove all mentions of it https://community.sonarsource.com/t/node-js-16-is-no-longer-supported-in-the-analysis-environment/112167

[saberduck]

The ticket mentions testing the CI against all active Node.js versions. This will really slow down our pull requests. Is it really something we want to do?

The tests would run in parallel, so they shouldn't slow down that much. However, it will consume more resources. I think testing against 18, 20, and 22 is reasonable.

[yassin-kammoun-sonarsource]

The ticket mentions testing the CI against all active Node.js versions. This will really slow down our pull requests. Is it really something we want to do?

The tests would run in parallel, so they shouldn't slow down that much. However, it will consume more resources. I think testing against 18, 20, and 22 is reasonable.

Alright. I will tackle the CI changes in a separate pull request.

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube