DS-510 Simplify the LinkBase implementation #200
+99
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregaubert
requested review from
david-cho-lerat-sonarsource and
jeremy-davis-sonarsource
✅ Deploy Preview for echoes-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| LinkBaseProps, | ||
| 'download' | 'hasExternalIcon' | 'isMatchingFullPath' | 'shouldOpenInNewTab' | 'to' | ||
| > & { hasExternalIcon?: boolean } & Pick< | ||
| DropdownMenuItemNavLinkProps, |
There was a problem hiding this comment.
NP: I would have expected to see DropdownMenuItemNavLinkProps defined before it is used - maybe move the type(s) up?
| {...restAndRadixProps} | ||
| onClick={handleClick} | ||
| ref={ref} | ||
| style={style} | ||
| to={to}> | ||
| {children} | ||
| </RouterLinkComponent> | ||
|
|
||
| {shouldOpenInNewTabProps && ( |
There was a problem hiding this comment.
NP: this would look better IMO as {shouldOpenInNewTab && (
| to={to}> | ||
| {children} | ||
|
|
||
| {shouldOpenInNewTabProps && ( |
There was a problem hiding this comment.
NP: this would look better IMO as {shouldOpenInNewTab && (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest we change linkbase to a simpler implementation where we extract the navlink part that is just for the DropdownMenuItemLink. It also allows to fully rely on the
shouldOpenInNewTabprops to display the external icon or not.