Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S2699: add support for supertest #3830

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Modify rule S2699: add support for supertest #3830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion rules/S2699/javascript/rule.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ When the unit test is executed, the assertions are evaluated. If all the asserti

Without assertions, a unit test doesn't actually verify anything, making it ineffective in catching potential bugs or regressions. It will always pass, regardless of the implementation of the unit. This can lead to a false sense of security, as you may believe that your code is working correctly when it might not be.

This rule raises an issue when the assertion library ``++chai++``,``++sinon++`` or ``++vitest++`` is imported but no assertion is used in a test.
This rule raises an issue when one of the following assertion libraries is imported but no assertion is used in a test:
- ``++chai++``
- ``++sinon++``
- ``++vitest++``
- ``++supertest++``

[source,javascript,diff-id=1,diff-type=noncompliant]
----
Expand Down