Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S1854 FP: Throw should connect to outer catch #9468

Closed
pavel-mikula-sonarsource opened this issue Jun 26, 2024 · 0 comments · Fixed by #9528
Closed

Fix S1854 FP: Throw should connect to outer catch #9468

pavel-mikula-sonarsource opened this issue Jun 26, 2024 · 0 comments · Fixed by #9528
Assignees
@mary-georgiou-sonarsource
Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Type: CFG/SE FPs Rule IS triggered when it shouldn't be for CFG and SE rules.
Milestone
9.30

Comments

@pavel-mikula-sonarsource
Copy link
Contributor

pavel-mikula-sonarsource commented Jun 26, 2024 •
edited by mary-georgiou-sonarsource
Loading

This is similar to #9466

    public void NestedCatchAndRethrow()
    {
        var value = 100;
        try
        {
            try
            {
                CanThrow();
            }
            catch
            {
                value = 200;    // Noncompliant FP
                throw;
            }
        }
        catch
        {
            Log(value);
        }
    }
pavel-mikula-sonarsource added a commit that referenced this issue Jun 26, 2024
@pavel-mikula-sonarsource
S1854: Add FP repro for #9466, #9467, #9468
5192baa
Merged
@pavel-mikula-sonarsource pavel-mikula-sonarsource added Area: CFG/SE CFG and SE related issues. Area: C# C# rules related issues. Type: CFG/SE FPs Rule IS triggered when it shouldn't be for CFG and SE rules. Sprint: LVA labels Jun 26, 2024
pavel-mikula-sonarsource added a commit that referenced this issue Jun 27, 2024
@pavel-mikula-sonarsource
S1854: Add FP repro for #9466, #9467, #9468 (#9469)
bb28b15
@mary-georgiou-sonarsource mary-georgiou-sonarsource added this to the 9.30 milestone Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mary-georgiou-sonarsource mary-georgiou-sonarsource

Labels
Area: C# C# rules related issues. Area: CFG/SE CFG and SE related issues. Type: CFG/SE FPs Rule IS triggered when it shouldn't be for CFG and SE rules.
Projects
None yet
Milestone
9.30
Development

Successfully merging a pull request may close this issue.

Fix S1854 FP: Throw should connect to outer catch SonarSource/sonar-dotnet
4 participants
@Tim-Pohlmann @pavel-mikula-sonarsource @mary-georgiou-sonarsource @sebastien-marichal