LVA: Add CfgSerializer.RoslynLvaWalker #9529
Conversation
sebastien-marichal
force-pushed
the
sma/lva-cfg-serializer
branch
from
d4fcd2f
to
27a7634
Compare
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned sebastien-marichal
sebastien-marichal
force-pushed
the
sma/lva-cfg-serializer
branch
from
27a7634
to
bd720e2
Compare
mary-georgiou-sonarsource
changed the title
| new RoslynCfgWalker(writer, new RoslynCfgIdProvider()).Visit(cfg, title); | ||
| return writer.ToString(); | ||
| } | ||
| public static string Serialize(RoslynLiveVariableAnalysis lva, string title = "RoslynCfg") |
There was a problem hiding this comment.
Not sure if it makes sense but I'd change the title to "RoslynCfgLVA" to avoid confusion in the future.
Like why I get this result here and another one in another case.
Like this, it might make it clear that this is a different CFG.
|
|
||
| protected override void WriteEdges(BasicBlock block) | ||
| { | ||
| foreach (var predecessor in lva.BlockPredecessors[block.Ordinal]) |
There was a problem hiding this comment.
This looks good but we are ignoring the ControlFlowBranches and their semantics - which probably should appear as edge labels :/
Please add couple of tests with while loops, if-else and foreach so we see how it looks there.
There was a problem hiding this comment.
I made some change to include semantic information 🎉
github-actions
bot
assigned sebastien-marichal and unassigned mary-georgiou-sonarsource
analyzers/tests/SonarAnalyzer.TestFramework/Extensions/StringAssertionsExtensions.cs
Outdated
Show resolved
Hide resolved
sebastien-marichal
requested review from
mary-georgiou-sonarsource and
pavel-mikula-sonarsource
github-actions
bot
assigned mary-georgiou-sonarsource and pavel-mikula-sonarsource and unassigned sebastien-marichal and mary-georgiou-sonarsource
sebastien-marichal
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
| @@ -36,9 +36,21 @@ public RoslynLvaWalker(RoslynLiveVariableAnalysis lva, DotWriter writer, RoslynC | |||
|
|
|||
| protected override void WriteEdges(BasicBlock block) | |||
| { | |||
| foreach (var predecessor in lva.BlockPredecessors[block.Ordinal]) | |||
| var lvaPredecessors = lva.BlockPredecessors[block.Ordinal]; | |||
There was a problem hiding this comment.
There's a lot of duplication now :/
Maybe it's possible to change what you need here and then call the base.WriteEdges?
Maybe you can also give the predecessors are input?
github-actions
bot
assigned sebastien-marichal and unassigned mary-georgiou-sonarsource
sebastien-marichal
force-pushed
the
sma/lva-cfg-serializer
branch
from
544f856
to
aa051f6
Compare
|
|
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned sebastien-marichal
The first commit is only CaYC.
I went a bit wild on cleaning...