Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPY-2095: Update pluginApiMinVersion in pom.xml #2052

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Seppli11
Copy link
Contributor

@Seppli11 Seppli11 commented Oct 9, 2024

No description provided.

@@ -78,7 +78,7 @@
<!-- Release: enable publication to Bintray -->
<artifactsToPublish>${project.groupId}:sonar-python-plugin:jar</artifactsToPublish>
<!-- we depend on API ${sonar.version} but we keep backward compatibility with LTS -->
<pluginApiMinVersion>9.9</pluginApiMinVersion>
<pluginApiMinVersion>10.11</pluginApiMinVersion>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above makes me a bit unsure if we're allowed to change this to 10.11, while still being compatible with the LTA.
The current LTA, 9.9, uses the plugin API version 9.13.0.360 (see here).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, on peach, version 10.7 has been installed, which uses the plugin API version 10.11.0.2468 (see here). Thus sonarqube 10.7 should be able to load the python-analyzer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we generally update this after LTA releases, from what I remember. It's probably best to verify this, though.

Copy link
Contributor Author

@Seppli11 Seppli11 Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the history, it looks like the pluginApiMinVersion/sonarQubeMinVersion were upgraded to the latest LTA version (or lower) but not above that.

Date Min SQ Version LTA at the time
06.10.2023 9.6 9.9
16.09.2019 7.9 7.9.6
16.01.2018 6.7 6.7

Copy link

sonarqube-next bot commented Oct 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants