Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQSCANGHA-38 Revert "SQSCANGHA-28 Support passing args with spaces" #131

Merged

Conversation

csaba-feher-sonarsource
Copy link
Contributor

@csaba-feher-sonarsource csaba-feher-sonarsource commented Jun 13, 2024

This reverts commit 16be80a.

It is required to Fix SQSCANGHA-38.

Please be aware that we are not actively looking for feature contributions. The truth is that it's extremely difficult for someone outside SonarSource to comply with our roadmap and expectations. Therefore, we typically only accept minor cosmetic changes and typo fixes. If you would like to see a new feature, please create a new thread in the forum "Suggest new features".

With that in mind, if you would like to submit a code contribution, make sure that you adhere to the following guidelines and all tests are passing:

  • Please explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Make sure any code you changed is covered by tests
  • If there is a JIRA ticket available, please make your commits and pull request start with the ticket ID (SONAR-XXXX)

We will try to give you feedback on your contribution as quickly as possible.

Thank You!
The SonarSource Team

@csaba-feher-sonarsource csaba-feher-sonarsource changed the title Revert "SQSCANGHA-28 Support passing args with spaces" [SQSCANGHA-38] Revert "SQSCANGHA-28 Support passing args with spaces" Jun 13, 2024
@csaba-feher-sonarsource csaba-feher-sonarsource changed the title [SQSCANGHA-38] Revert "SQSCANGHA-28 Support passing args with spaces" SQSCANGHA-38 Revert "SQSCANGHA-28 Support passing args with spaces" Jun 13, 2024
Copy link
Member

@henryju henryju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on the SSF.

@csaba-feher-sonarsource csaba-feher-sonarsource merged commit 540792c into master Jun 13, 2024
8 checks passed
@JDESTM
Copy link

JDESTM commented Jun 14, 2024

Hi,
This revert of spaces support in args had a direct impact on our SonarQube scan launch.
What's the proper way to use version >v2.1.0 with properties having spaces ? Properties file ?

@henryju henryju deleted the bugfix/cfeher/SQSCANGHA-38-Fix-SSF-599 branch September 19, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants