Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade AWS SDK for Go from V1 to V2 #78

Merged
merged 7 commits into from
Oct 8, 2023
Merged

Upgrade AWS SDK for Go from V1 to V2 #78

merged 7 commits into from
Oct 8, 2023

Commits on Sep 17, 2023

  1. wip: aws.go

    @snaka
    snaka committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    14c9d49 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. fix PropagateTags

    @snaka
    snaka committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    85558bf View commit details
    Browse the repository at this point in the history

  2. fix: Slice of Rules type 

    The type of `r.Rules` has been changed from pointer type to value type
since SDK V2.

When a value is retrieved from value type using `for ... range`, the
pointer of the loop variable that stores the value is fixed.

That causes the problem that all elements of slice eventually refer to
the same pointer.
To avoid that problem, change the base of slice from pointer type to
value type.
    @snaka
    snaka committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b503407 View commit details
    Browse the repository at this point in the history

  3. fix: Replace Redundant Array Loops with Splat Operator

    @snaka
    snaka committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    e6b308e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Merge branch 'main' into aws-sdk-go-v2

    @Songmu
    Songmu committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    7a747d0 View commit details
    Browse the repository at this point in the history

  2. fix test.yaml

    @Songmu
    Songmu committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    ba2f86f View commit details
    Browse the repository at this point in the history

  3. fix test.yaml

    @Songmu
    Songmu committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    a5f182b View commit details
    Browse the repository at this point in the history