Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix retrievingVersionFromFile #108

Merged
merged 1 commit into from
Sep 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions testdata/vfile1
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
0.1.2
version 1.2.3
1 change: 1 addition & 0 deletions testdata/vfile2
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1.3.5
23 changes: 16 additions & 7 deletions versionfile.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,15 @@ import (
"github.com/saracen/walker"
)

const versionRegBase = `(?i)((?:^|[^-_0-9a-zA-Z])version[^-_0-9a-zA-Z].{0,50})`
const (
versionRegBase = `(?i)((?:^|[^-_0-9a-zA-Z])version[^-_0-9a-zA-Z].{0,50})`
semverRegBase = `([0-9]+\.[0-9]+\.[0-9]+)`
)

var (
versionReg = regexp.MustCompile(versionRegBase + `([0-9]+\.[0-9]+\.[0-9]+)`)
skipDirs = map[string]bool{
versionReg = regexp.MustCompile(versionRegBase + semverRegBase)
versionRegFallback = regexp.MustCompile(semverRegBase)
skipDirs = map[string]bool{
// The "testdata" directory is ommited because of the test code for tagpr itself
"testdata": true,
".git": true,
Expand Down Expand Up @@ -190,11 +194,16 @@ func retrieveVersionFromFile(fpath string, vPrefix bool) (*semv, error) {
if err != nil {
return nil, err
}
m := versionReg.FindSubmatch(bs)
if len(m) < 3 {
return nil, fmt.Errorf("no version detected from file: %s", fpath)
var ver string
if m := versionReg.FindSubmatch(bs); len(m) >= 3 {
ver = string(m[2])
} else {
m := versionRegFallback.FindSubmatch(bs)
if len(m) < 2 {
return nil, fmt.Errorf("no version detected from file: %s", fpath)
}
ver = string(m[1])
}
ver := string(m[2])
if vPrefix {
ver = "v" + ver
}
Expand Down
10 changes: 10 additions & 0 deletions versionfile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,16 @@ func TestRetrieveVersionFile(t *testing.T) {
if ver.Naked() != version {
t.Errorf("detected: %s, expected: %s", ver.Naked(), version)
}

ver, err = retrieveVersionFromFile("testdata/vfile1", true)
Songmu marked this conversation as resolved.
Show resolved Hide resolved
if e, g := "v1.2.3", ver.Tag(); e != g {
t.Errorf("got: %s, expected: %s", g, e)
}

ver, err = retrieveVersionFromFile("testdata/vfile2", false)
Songmu marked this conversation as resolved.
Show resolved Hide resolved
if e, g := "1.3.5", ver.Tag(); e != g {
t.Errorf("got: %s, expected: %s", g, e)
}
}

func TestDetectVersionFile(t *testing.T) {
Expand Down