-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchIssues related testing and refactoring #121
SearchIssues related testing and refactoring #121
Conversation
tagpr_test.go
Outdated
def3db8 | ||
c0fc143 | ||
`, | ||
"repo:k2tzumi/runn is:pr is:closed 1a8bb97 1b7691b a9462b9 4d2b5e9 9ce4268 1eccbf8 1c3fbfc 968ade5 531c782 780bb71 6025fbf cc369ba a1f3e39 792bc85 3e3c4e1 37832de ac97702 d742186 217eb5d 0f900f7 5ef33d1 1d2ec15 2f37752 066ad7b 2e19b14 52b3706 f5134ae ea39bbf 76b0630 ee3c6e6 2336be4 423a209 63caa74", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected value at failure.
The correct number of characters was within 256 bytes.
https://github.com/k2tzumi/tagpr/actions/runs/3167204019/jobs/5157515466#step:4:30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mistakenly thought you were truncating the commit log.
e42fb98
to
c954883
Compare
query += " " + sha | ||
} | ||
if query != queryBase { | ||
for _, query := range buildChunkSearchIssuesQuery(queryBase, shasStr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using range
is very smart!
tagpr.go
Outdated
chunkQueries = append(chunkQueries, query) | ||
query = queryBase | ||
|
||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't continue here. Current sha should be appended to the query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I fixed it 2f52564
Good job. Thank you. |
Motivation for creating PR
The following error occurred in the tagpr workflow
https://github.com/k2tzumi/runn/actions/runs/3166757995/jobs/5156706551#step:3:303
I wrote a verification code to investigate the cause.
Revision details