Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

true/false/draft for tapgr.release config #96

Merged
merged 1 commit into from
Sep 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions config.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const (
# Pull request template in go template format
#
# tagpr.release (Optional)
# GitHub Release creation behavior after tagging [yes, draft, no]
# GitHub Release creation behavior after tagging [true, draft, false]
# If this value is not set, the release is to be created.
[tagpr]
`
Expand Down Expand Up @@ -234,12 +234,18 @@ func (cfg *config) Template() string {
return stringify(cfg.template)
}

func (cfg *config) Release() string {
func (cfg *config) Release() bool {
rel := strings.ToLower(stringify(cfg.release))
switch rel {
case "yes", "draft", "no":
return rel
default:
return "yes"
if rel == "draft" || rel == "" {
return true
}
b, err := strconv.ParseBool(rel)
if err != nil {
return true
}
return b
}

func (cfg *config) ReleaseDraft() bool {
return strings.ToLower(stringify(cfg.release)) == "draft"
}
23 changes: 11 additions & 12 deletions tag.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,18 +95,17 @@ func (tp *tagpr) tagRelease(ctx context.Context, pr *github.PullRequest, currVer
return err
}

if rel := tp.cfg.Release(); rel == "no" {
if !tp.cfg.Release() {
return nil
} else {
// Don't use GenerateReleaseNote flag and use pre generated one
_, _, err = tp.gh.Repositories.CreateRelease(
ctx, tp.owner, tp.repo, &github.RepositoryRelease{
TagName: &nextTag,
TargetCommitish: &releaseBranch,
Name: &releases.Name,
Body: &releases.Body,
Draft: github.Bool(rel == "draft"),
})
return err
}
// Don't use GenerateReleaseNote flag and use pre generated one
_, _, err = tp.gh.Repositories.CreateRelease(
ctx, tp.owner, tp.repo, &github.RepositoryRelease{
TagName: &nextTag,
TargetCommitish: &releaseBranch,
Name: &releases.Name,
Body: &releases.Body,
Draft: github.Bool(tp.cfg.ReleaseDraft()),
})
return err
}