More verbose output: Report passed tests, tool invocations. #763
Conversation
When running the test suite interactively, I want to see know what it's currently doing and what the current state of success is. This is actually already logged, but with log level debug and we have no way to make this visible by cmd line options. Rather than introducing an option '-d|--debug', let's just attach it to '-v|--verbose', as it does not add all that much output. Also, when used with '-v', let's also report all passed checks in the summary. Signed-off-by: Kurt Garloff <[email protected]>
garloff
added
enhancement
|
@garloff Just FYI: The tool does have |
Tests/scs-compliance-check.py
Outdated
| @@ -109,6 +109,7 @@ def apply_argv(self, argv): | |||
| sys.exit(0) | |||
| elif opt[0] == "-v" or opt[0] == "--verbose": | |||
| self.verbose = True | |||
| logger.setLevel(logging.DEBUG) | |||
There was a problem hiding this comment.
I would prefer to keep this decoupled from --debug (see the next two lines). Callers can always pass -v --debug if they like. However, if that is not user friendly enough, we might consider improving the log output even further, because currently, you cannot tell when running CMD... is not running anything for real (because this CMD has already been memoized from a previous run), except that stdout is not repeated in that case.
There was a problem hiding this comment.
I must have overlooked the --debug setting, sorry ...
There was a problem hiding this comment.
OK, changed it to only enable --debug upon a second --verbose or -vv, which is in line with how many CLI tools behave.
I hope that this finds your support.
This makes -vv enable --debug, which is in line with many tools. Signed-off-by: Kurt Garloff <[email protected]>
|
Fine by me! |
When running the test suite interactively, I want to see know what it's currently doing and what the current state of success is. This is actually already logged, but with log level debug and we have no way to make this visible by cmd line options. Rather than introducing an option
-d|--debug, let's just attach it to-v|--verbose, as it does not add all that much output.Also, when used with
-v, let's also report all passed checks in the summary.