Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trims off effect layers, makes rendering a bit more sane #295

Merged

Conversation

LemonInTheDark
Copy link
Contributor

@LemonInTheDark LemonInTheDark commented Jul 5, 2024

Description

The existing multiplier is lower then layer values encouraged by byond when combined with layering defines, so it breaks easy. I'm removing effect layers which should make the value at least a little more sane (though at a max of 4999 there is still risk of intermixing, should we be using float64 or someodd?)

I was not able to get the build process to work, so this is unfortunately untested. Apologies. Should close #292

Type of change

  • Minor changes or tweaks (quality of life stuff)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

The existing multiplier is lower then layer values encoraged by byond,
so it breaks easy. Hopefully a larger value will help here.
@LemonInTheDark
Copy link
Contributor Author

LemonInTheDark commented Jul 5, 2024

I had to bump the multiplier up significantly, I am like 90% sure this is starting to edge on floating point rounding errors.
Why do we multiply layer by 1000? is it to handle tiny baby values? could the final layer be a float 64 or would that break something? (Would it be worth removing applied effect layers (TOPDOWN_LAYER, EFFECT_LAYER, BACKGROUND_LAYER) as well as doing this to reduce the final value?)

Please advise

NVM I'm doing it

Done

@LemonInTheDark LemonInTheDark changed the title Adds a wider span for layers without mixup with planes Trims off effect layers, makes rendering a bit more sane Jul 5, 2024
@SpaiR SpaiR added the fix Fix for the issue label Jul 5, 2024
@SpaiR
Copy link
Owner

SpaiR commented Jul 5, 2024

@LemonInTheDark I've fixed the pipeline. Please update the PR to the latest main to proceed with CI

@SpaiR SpaiR merged commit 47c9aa0 into SpaiR:main Jul 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix for the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SDMM layer wonkiness
2 participants