guess attachment mimetype in Django email backend if not provided #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is an issue I ran into while using django-post-office. The django
EmailMessage.attach
method does not require you to submit a mimetype, stating that it is guessed if not provided. Unfortunately the django-post-office API does not support specifying a mime type, meaning I have no choice but to rely on the guessing mechanism. Long story short, I cannot currently attach any files to my emails.The email backend would normally let the EmailMessage class do this when converting the email to MIME format (see the
EmailMessage.message
method which eventually calls EmailMessage._create_attachment). Obviously the sparkpost backend does not call any of this code.I've duplicated django's method of guessing the mimetype into the sparkpost backend. I've also added two tests to demonstrate the problem.