Skip to content

Commit

Permalink
Merge pull request godotengine#97979 from BlueCube3310/fix-thumb-gen
Browse files Browse the repository at this point in the history
Fix crash when creating thumbnails for 3d textures
  • Loading branch information
Repiteo committed Oct 10, 2024
2 parents e589074 + 203f742 commit 92e51fc
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions editor/plugins/editor_preview_plugins.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,13 @@ Ref<Texture2D> EditorTexturePreviewPlugin::generate(const Ref<Resource> &p_from,
return Ref<Texture2D>();
}

const int mid_depth = (tex_3d->get_depth() - 1) / 2;

Vector<Ref<Image>> data = tex_3d->get_data();
if (data.size() != tex_3d->get_depth()) {
return Ref<Texture2D>();
}

// Use the middle slice for the thumbnail.
const int mid_depth = (tex_3d->get_depth() - 1) / 2;
if (!data.is_empty() && data[mid_depth].is_valid()) {
img = data[mid_depth]->duplicate();
}
Expand All @@ -124,6 +128,7 @@ Ref<Texture2D> EditorTexturePreviewPlugin::generate(const Ref<Resource> &p_from,
return Ref<Texture2D>();
}

// Use the middle slice for the thumbnail.
const int mid_layer = (tex_lyr->get_layers() - 1) / 2;

Ref<Image> data = tex_lyr->get_layer_data(mid_layer);
Expand Down

0 comments on commit 92e51fc

Please sign in to comment.