Skip to content

Commit

Permalink
fix bug #3865 (#3873)
Browse files Browse the repository at this point in the history
* fix bug #3865

* remove spaces

* Updated the changelog

---------

Co-authored-by: maisur <[email protected]>
  • Loading branch information
chickgit and maisur authored Feb 16, 2023
1 parent 4fca093 commit b79b0d4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Fixed
- Fix Bug Multiple drawings change the behavior of the startCell (#3865).

## [3.1.46] - 2023-01-27

- Support Laravel 10
Expand Down
8 changes: 4 additions & 4 deletions src/Sheet.php
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,6 @@ public function open($sheetExport)
if ($sheetExport instanceof WithCharts) {
$this->addCharts($sheetExport->charts());
}

if ($sheetExport instanceof WithDrawings) {
$this->addDrawings($sheetExport->drawings());
}
}

/**
Expand Down Expand Up @@ -398,6 +394,10 @@ public function toCollection($import, int $startRow = null, $nullValue = null, $
*/
public function close($sheetExport)
{
if ($sheetExport instanceof WithDrawings) {
$this->addDrawings($sheetExport->drawings());
}

$this->exportable = $sheetExport;

if ($sheetExport instanceof WithColumnFormatting) {
Expand Down

0 comments on commit b79b0d4

Please sign in to comment.