Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated JetBrains.Rider.SDK package versions to the latest release. #203

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Updated JetBrains.Rider.SDK package versions to the latest release. #203

merged 6 commits into from
Nov 14, 2023

Conversation

ajeckmans
Copy link
Contributor

Set until-build in plugin metadata to * to allow marketplace mechanism to determine if the plugin will work with newer Rider versions or not.
Fixes #202

Set until-build in plugin metadata to * to allow marketplace mechanism to determine if the plugin will work with newer Rider versions or not.
@ajeckmans
Copy link
Contributor Author

I had to update the version of NUnit3TestAdapter because it failed on some weird error about not knowing SDK 7 (even though I have that installed). The newer version fixed that.

@Socolin
Copy link
Collaborator

Socolin commented Nov 10, 2023

Hello, the version need to be updated in gradle.properties too.

@ajeckmans
Copy link
Contributor Author

Then this will be it right?

@ajeckmans
Copy link
Contributor Author

@Socolin The build is working locally as well as the gradlew thing. There are some warnings, but nothing major. I'm not sure why it is failing in the build itself?

@Socolin
Copy link
Collaborator

Socolin commented Nov 10, 2023

Since it fail during the protocol steps maybe the package need to be updated too (top of build.gradle 'com.jetbrains.rdgen')

@ajeckmans
Copy link
Contributor Author

This is my first time "working" on a plugin for rider/resharper, but wow.. this is getting way more complicated than expected :)

@Socolin
Copy link
Collaborator

Socolin commented Nov 10, 2023

You should not replace the variable here

-    <PackageReference Include="JetBrains.Rider.SDK" Version="$(SdkVersion)" />
+    <PackageReference Include="JetBrains.Rider.SDK" Version="2023.2.3" />

This need to be updated in the .props file

@Socolin
Copy link
Collaborator

Socolin commented Nov 10, 2023

This is my first time "working" on a plugin for rider/resharper, but wow.. this is getting way more complicated than expected :)

For every release I have to take 1 evening to updates all my plugin and find the right combinaison of version for gradle, jvm, nugets, etc...

One way to find out the version to use is to check https://github.com/JetBrains/resharper-rider-plugin

@ajeckmans
Copy link
Contributor Author

I will look at that this evening then.

Also I changed the version in the wrong file initially. Then corrected it and did the unspeakable: an amend and force push, so your local history might be different now. Sorry for that :)

@Socolin
Copy link
Collaborator

Socolin commented Nov 10, 2023

No problem with force push :)

@ajeckmans
Copy link
Contributor Author

Took a few days, but I was able to reproduce locally and now have no build issues anymore.

@ajeckmans
Copy link
Contributor Author

@Socolin and now? 😄

@Socolin
Copy link
Collaborator

Socolin commented Nov 14, 2023

Look good thanks ! :)

I'll submit a new version and in 1 or 2 days it should be available, if you want to install on your side you can install from zip (there is a button for that in the Plugin UI)

@Socolin Socolin merged commit cecd696 into SpecFlowOSS:master Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants