Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3464 add modified/modifiedBy to CoLDP exporter #3479

Merged
merged 6 commits into from
Jul 5, 2023
Merged

Conversation

gdower
Copy link
Contributor

@gdower gdower commented Jul 3, 2023

This adds modified date and modifiedBy (as either orcid or name) to the coldp exporter for all files
It also changes the User.orcid to use identifier instead of cache like the Person model

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Patch coverage: 72.72% and no project coverage change.

Comparison is base (78b9cea) 85.84% compared to head (a692fa1) 85.84%.

❗ Current head a692fa1 differs from pull request most recent head 5da79e3. Consider uploading reports for the commit 5da79e3 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##           development    #3479   +/-   ##
============================================
  Coverage        85.84%   85.84%           
============================================
  Files             2005     2005           
  Lines            72463    72475   +12     
============================================
+ Hits             62203    62214   +11     
- Misses           10260    10261    +1     
Impacted Files Coverage Δ
lib/export/coldp/files/description.rb 46.15% <33.33%> (ø)
lib/export/coldp/files/vernacular_name.rb 45.00% <33.33%> (ø)
lib/export/coldp/files/taxon.rb 50.00% <50.00%> (ø)
lib/export/coldp/files/name.rb 46.98% <60.00%> (ø)
lib/export/coldp/files/synonym.rb 30.76% <66.66%> (ø)
lib/export/coldp.rb 81.69% <93.75%> (+2.02%) ⬆️
app/models/person.rb 89.95% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mjy mjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdower looks great, thanks. A couple very minor bits/Qs.

app/models/person.rb Outdated Show resolved Hide resolved
lib/export/coldp.rb Outdated Show resolved Hide resolved
lib/export/coldp.rb Outdated Show resolved Hide resolved
@mjy mjy merged commit 453e68f into development Jul 5, 2023
7 checks passed
@mjy mjy deleted the 3464_coldp_modified branch July 5, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants