Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some AlternateValueAnnotator component updates #4082

Merged

Conversation

kleintom
Copy link
Contributor

STR: Find a radial annotator for something that has alternate values, like GAs, open the Alternate Values panel from the radial.

  • Exceptions when you try to edit an Abbreviation, Misspelling, or Alternate Spelling (due to an exception on Language.find(null)) - those are the alternate value options that don't set a language
  • Exception/unable to delete the existing language when editing a Translation (due to a language parameter shadowing a language ref I think)
  • Vue warnings in the console in development about AlternateValueAnnotator not having a root node - I added a root div which silences the warnings and looks right, I think that's the right fix here? (Sorry the diff on that is so mangled here)

Previously unable to delete the existing language when editing a Translation do to an exception trying to assign the value `language.value` where `language` is the null function parameter and not the intended ref.
To keep vue from complaining about it.
@jlpereira jlpereira merged commit 631297b into SpeciesFileGroup:development Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants