Merging changes from 'dsccommunity/SqlServerDsc' main. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SqlServerDsc
- The variable `$env:COMPUTERNAME` does not exist cross-platform which
hinders development and testing on macOS and Linux. Instead the
resources have been update to use the helper function `Get-ComputerName`
which returns the current computer name cross-plattform.
- SqlProtocol
- The verbose messages now correctly show that `$env:COMPUTERNAME` is used
to get or set the configuration, while parameter **ServerName** is used
to restart the instance.
- SqlProtocolTcpIp
- The verbose messages now correctly show that `$env:COMPUTERNAME` is used
to get or set the configuration, while parameter **ServerName** is used
to restart the instance.
- SqlSetup
- When the SqlSetup detects that the expected components was not installed
and consequently throws an exception, that exception message now presents
a link to an article on how to find the SQL Server setup logs (issue #1420).
- SqlRSSetup
- If parameter `EditionUpgrade` is set to `$false` the `/EditionUpgrade`
argument is no longer wrongly added (issue #1398).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.