Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use path nested for sd-jwt #140

Conversation

TimoGlastra
Copy link
Contributor

See answer from Torsten here: openid/oid4vc-haip-sd-jwt-vc#76 (comment)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ba2080) 94.16% compared to head (e49063e) 94.38%.

❗ Current head e49063e differs from pull request most recent head f031236. Consider uploading reports for the commit f031236 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #140      +/-   ##
===========================================
+ Coverage    94.16%   94.38%   +0.21%     
===========================================
  Files           64       64              
  Lines         2366     2368       +2     
  Branches       548      549       +1     
===========================================
+ Hits          2228     2235       +7     
+ Misses         133      129       -4     
+ Partials         5        4       -1     
Flag Coverage Δ
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nklomp nklomp merged commit 399c154 into Sphereon-Opensource:develop Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants