feature/funke-mdoc

[sanderPostma]

mdoc support in types

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (6023f0e) to head (66db088).
Report is 24 commits behind head on develop.

Files with missing lines	Patch %	Lines
...uation/handlers/didRestrictionEvaluationHandler.ts	0.00%	3 Missing and 1 partial ⚠️
lib/PEX.ts	88.88%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #166      +/-   ##
===========================================
- Coverage    93.76%   93.59%   -0.17%     
===========================================
  Files           66       66              
  Lines         2629     2638       +9     
  Branches       662      665       +3     
===========================================
+ Hits          2465     2469       +4     
- Misses         161      165       +4     
- Partials         3        4       +1     

Flag	Coverage Δ
unittest	93.59% <61.53%> (-0.17%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sanderPostma]

It has a FIXME in there, but this is not a new situation. We still pass the same data into isSdJwtDecodedCredential, typescript just got in the way suddenly.

[nklomp]

That comment makes no sense IMO. Obviously the types changed

[sanderPostma]

SdJwtDecodedVerifiableCredentialWithKbJwtInput does not overlap with SdJwtDecodedVerifiableCredential
Was is not matching is local type

export interface SdJwtKbJwtInput {
  header: {
    typ: 'kb+jwt';
  };
  payload: {
    iat: number;
    sd_hash: string;
    nonce?: string;
  };
}

vs in SSI-SDK

  kbJwt?: {
    compact: CompactJWT
    payload: SdJwtVcKbJwtPayload
  }

[sanderPostma]

@nklomp
We have the latest SSI types available now in PEX, so perhaps PresentationResult should be like this now

export interface PresentationResult {
  /**
   * The resulting presentation, can have an embedded submission data depending on the location parameter
   */
  presentation: OriginalVerifiablePresentation;

[sanderPostma]

I synched it up with ssi-types, but since some of the fields in header & payload have to be loaded by the signer I had to change the types a bit

export type PartialSdJwtKbJwt = {
  header: Partial<SdJwtVcKbJwtHeader>;
  payload: Partial<SdJwtVcKbJwtPayload>;
};

export type PartialSdJwtDecodedVerifiableCredential = Omit<SdJwtDecodedVerifiableCredential, 'kbJwt'> & { kbJwt: PartialSdJwtKbJwt };

[sksadjad]

small changes requested

[sksadjad]

lgtm

[TimoGlastra]

@sanderPostma I think this is a mistake, and shouldn't have been added here. The hashAlg is different from the signing alg.

[sanderPostma]

correct, I already removed it from verifiablePresentationFrom but in constructPresentation it's still there