This repository has been archived by the owner on Oct 2, 2024. It is now read-only.
fix: check presentation callback result #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
force-pushed
the
fix/presentation-callback-result
branch
from
4954159
to
6546ffc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used the
verifiedproperty in the presentation verification callback as return value, but noticed that presentations would still be marked as'verified'even if the presentation was invalid.It seems the PresetnationExchange only check if an error was thrown and didn't use the return property
verified. This PR makes sure both error andverifier: falseare handled.It also adds a
reasonso the implementer can provide a reason why the verification failed.I tried to write some tests for it, but somehow jest just straight up exists or only throws the error at the next test, even though I use await expect(Promise).rejects.toThrow(). Not sure what is happening here