Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new module for benchmark. Implement SorterStudy that replace GroundTruthStudy #3396

Merged
merged 12 commits into from
Oct 7, 2024

Conversation

samuelgarcia
Copy link
Member

@samuelgarcia samuelgarcia commented Sep 11, 2024

This is continuation of the work presented by @yger in Edingurgh workshop : faster and easier benchmarks.

This PR:

  • create a new module for spikeinterface.benchmark
  • replace GroundTruthStudy by SorterStudy. similar API but not backward compatible.
  • move the BenchmarkStudy and Benchmark base class from spikeinterface.sortingcomponents.benchmark
    to spikeinterface.benchmark
  • move all components benchmark to the same submodule
  • refactor plotting to share plots across benchmarks
  • remove plotting related to benchmark in spikeinterface.widgets

@samuelgarcia
Copy link
Member Author

@chris-langfield and @cwindolf
if you are doing benchmark for dartsort you should have a look to this.

@alejoe91 alejoe91 added the comparison Related to comparison module label Sep 12, 2024
Copy link
Collaborator

@yger yger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alea jacta es

@yger yger merged commit 3522a07 into SpikeInterface:main Oct 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comparison Related to comparison module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants