-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement XML configuration loader #90
Conversation
This is no longer WIP. I'd welcome any feedback / comments. |
I had given up hope. I'm in love with you @lucko <3 |
1070ae5
to
be99641
Compare
Bump - any update on the status of this? |
I'd want to see this merged after #92. |
Can you update this with the other changes, as well as style changes you previously made? |
7285085
to
cf4220a
Compare
I've rebased this against master and updated the style to match the other changes. I've also fixed an issue with the way lists were serialised, and added a few more tests. Should be good to be reviewed/merged now. :) |
0d30d11
to
a102ad4
Compare
I will give this a look soon, but I'd also like to see @zml2008's feedback as this is a fairly large change, adding a completely new loader. |
Every xml file(since xml 1.1) must start with xml header. Also, you don't handle XML comments system. |
Thanks for your feedback.
Could you elaborate a bit more on exactly what you mean by this? I don't really understand what you're talking about.
The loader already had the option to include the header, I've now set it to be enabled by default. Thanks :)
The page you linked doesn't make much sense to me. The native Java library being used for parsing doesn't seem to support anything other than String-String pairs for attributes. https://docs.oracle.com/javase/7/docs/api/org/w3c/dom/Attr.html
I've implemented an appropriate comment handler now and added a test. |
If no, impl is wrong. |
No, the comment handler forms comments like this
It will still correctly parse your example |
Yea, will need to be rebased. I'm not sure what the status is, I would prefer to gather more feedback / approval from people before this is merged though. |
a494aba
to
7e32f5f
Compare
It's rebased now, so can be merged when ready. I've also added a few more tests. |
@Meronat Please review so we can get this merged. |
Thanks, @lucko. |
Implements #57