Fix object mapping interface/abstract field types #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Serialize the instance's type rather than the interface/abstract type (which I believe was the intention). - Check that deserialized classes are children of the TypeSerializer's raw type. - Replace 'Class.getCanonicalName' with 'Class.getName' which returns the correct string for calls to 'Class.forName'. - Added interface serialization test to ObjectMapperTest
dags-
changed the title
kashike
suggested changes
Mar 9, 2018
| import java.util.Map; | ||
| import java.util.Optional; | ||
| import java.util.UUID; | ||
| import java.util.*; |
parlough
approved these changes
Apr 28, 2018
kashike
approved these changes
Apr 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For interface/abstract classes, the TypeSerializer currently adds a
__class__node whose value is the canonical name of the interface/abstract class. This isn't very useful when it comes to deserialization since we want to know the concrete type in order to instantiate and populate.This PR changes the behaviour so that, during serialization, it's the instance's class that is used in the
__class__node instead (which I believe was the original intention).