Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded updates are pruned by subsequent update checks #174

Closed
joshaber opened this issue Jun 8, 2016 · 1 comment
Closed

Downloaded updates are pruned by subsequent update checks #174

joshaber opened this issue Jun 8, 2016 · 1 comment
Assignees

Comments

@joshaber
Copy link
Contributor

joshaber commented Jun 8, 2016

This was introduced by #171 🙈:

  1. Check for updates.
  2. Prune existing downloads.
  3. Download an update.
  4. Check for updates.
  5. Prune existing downloads.
  6. Conditional GET means we don't re-download.
  7. Now we don't have an update downloaded anymore.
@joshaber joshaber changed the title Downloaded updates are deleted by subsequent update checks Downloaded updates are pruned by subsequent update checks Jun 8, 2016
@joshaber
Copy link
Contributor Author

joshaber commented Jun 8, 2016

Interestingly, this means we've always had the possibility that:

  1. Check for updates.
  2. Prune existing downloads.
  3. Download an update.
  4. Check for updates.
  5. Prune existing downloads.
  6. Quit the app.
  7. We try to install an update that's no longer downloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant