Automate registry registration for tasks #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than manually build the registry, this iterates overall subtasks of Task to build it. This makes registry entries less manual and error prone, and removes redundant code. This is not complete. There are two main issues: 1. Registry manipulation functions (with names like `create_tasks`) should be removed. 2. For older English tasks with multiple versions, tasks aren't added to the registry properly. Neither of these are complicated, they will be added in further commits.
This restores the manual creation of the registry for non-Japanese tasks. While it's possible to register them automatically, the mapping of the module or class name to the task name varies considerably, so it would require a lot of special casing to get it right.
polm-stability
requested review from
mrorii and
mkshing
and removed request for
jon-tow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks are managed in a registry. Historically this registry is a manually updated giant dictionary. This PR adds code that automates adding functions to the registry, which reduces the potential for mistakes and removes redundant code.
Currently this only handles Japanese tasks. It's hard to automate this for all existing tasks because the relation of the task name (the dictionary key) to the class or file names is very inconsistent. While updating the code to add manual specifications wouldn't be difficult, there are so many tasks it would take a while, so for now older tasks have just been left as-is.