Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't use that module with angular-cli optimized builds #128

Closed
ToGoBananas opened this issue Sep 14, 2017 · 5 comments
Closed

can't use that module with angular-cli optimized builds #128

ToGoBananas opened this issue Sep 14, 2017 · 5 comments
Milestone
5.0.0

Comments

@ToGoBananas
Copy link

ToGoBananas commented Sep 14, 2017 •
edited
Loading

Hi
I am using angular/cli=1.4.2, typescript=2.5.2 and latest version of Angular2-Toaster
I am trying to compile my app like ng build -e=prod -aot --build-optimizer, but I have these errors:
image
my component
image
problematic line in toaster.js
image
@ToGoBananas
Copy link
Author

ToGoBananas commented Sep 14, 2017 •
edited
Loading

It looks like easy issue to fix, but I just wodering why BodyOutputType.Default expression fails

@ToGoBananas
Copy link
Author

I think I just need to override configs, but maybe you want to fix that issue

@Stabzs
Copy link
Owner

Stabzs commented Sep 15, 2017

This is very curious...the BodyOutputType IS defaulted intentionally. I suspect this is due to the optimize flag attempting dead code elimination and it may believe the property isn't needed. I will try to reproduce.

Stabzs added a commit that referenced this issue Feb 5, 2018
@Stabzs
feat(Angular 5 release candidate)
0f474fd 
5.0.0 alpha release candidate.  See changelog for details.  Addresses:

#128, #129, #139 and #142
@Stabzs
Copy link
Owner

Stabzs commented Feb 23, 2018

This is currently fixed in 5.0.0-beta.1 and will be released in the full 5.0.0 release.

@Stabzs Stabzs added this to the 5.0.0 milestone Feb 23, 2018
Stabzs added a commit that referenced this issue Feb 24, 2018
@Stabzs
feat(version)
9c0e174 
Full relesae of 5.0.0.  Closes #144, #129, #142, #139 and #128.
Stabzs added a commit that referenced this issue Feb 24, 2018
@Stabzs
feat(README)
b495954 
Added back in 4.0.0 instructions
Fixed outdated package
Closes #144, #129, #142, #139 and #128.
@Stabzs
Copy link
Owner

Stabzs commented Feb 24, 2018

Released in 5.0.0.

@Stabzs Stabzs closed this as completed Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@ToGoBananas @Stabzs