Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular ErrorHandler #169

Closed
dgsqrs opened this issue May 28, 2018 · 2 comments
Closed

Angular ErrorHandler #169

dgsqrs opened this issue May 28, 2018 · 2 comments

Comments

@dgsqrs
Copy link

dgsqrs commented May 28, 2018

Hi there
This is not a bug but a feature/example request.

I have a custom ErrorHandler. My custom implementation is very simple, it implements the interface ErrorHandler and overwrite the handleError(error) method.
Because the ErrorHandler does not operate in a Angular Zone, the toasts don't show up correctly. I found the way to do it here : https://stackoverflow.com/questions/44975477/angular2-ng-toasty-errorhandler

The request : Can you add an example of the "correct" way to implement this kind of handler ?
Thanks !

@Stabzs
Copy link
Owner

Stabzs commented May 29, 2018

Thank you for opening this. This is a common “complaint” and having a definitive solution is an excellent thing.

I’ll add an example to both the angular-cli app and the documentation.

Stabzs added a commit that referenced this issue Jun 21, 2018
Added bypassSecurityTrustHtml support for the body parameter for the `TrustedHtml` body output type.  Thanks to @TGNC for making the change.

Documented ErrorHandler cases.  Closes #169.
@Stabzs
Copy link
Owner

Stabzs commented Jun 21, 2018

This has been added as part of the 6.1.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants