Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body is not updated when bodyOutputType is TrustedHtml #186

Closed
rmeshksar opened this issue Feb 14, 2019 · 3 comments
Closed

Body is not updated when bodyOutputType is TrustedHtml #186

rmeshksar opened this issue Feb 14, 2019 · 3 comments
Assignees
Labels

Comments

@rmeshksar
Copy link

When the toast object is created, updating the title and body values of the object should update the toast component.
It works well in default mode and title is working in all cases.
However, when the bodyOutType is TrustedHtml, the body in the component is not getting updated.
It is due to the fact that the trusted html for the body is only calculated in the component initialization phase and not reacting to the changes.
The solution to this is to use sanitizeHtml pipe and apply it to the toast.body in the component template.

I create this PR to fix this issue:
#185

That would be great if it can be reviewed and merged if it is all fine.

@Stabzs
Copy link
Owner

Stabzs commented Feb 20, 2019

I missed the PR. Thank you for opening this issue to bring this to my attention and thank you for the contribution. I will absolutely review it!

@Stabzs Stabzs self-assigned this Feb 20, 2019
@Stabzs Stabzs added the bug label Feb 20, 2019
@rmeshksar
Copy link
Author

Any update on this,

@Stabzs
Copy link
Owner

Stabzs commented Dec 1, 2020

This has been fixed in version 11.0.0.

@Stabzs Stabzs closed this as completed Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants